spikeinterface icon indicating copy to clipboard operation
spikeinterface copied to clipboard

CI error on Windows tests

Open zm711 opened this issue 1 year ago • 7 comments

Error message

RuntimeError: GitHub rate limit exceeded and GITHUB_TOKEN not set; suggest setting GITHUB_TOKEN in order to get increased rate limit

It suggests setting a token. Should we do that to prevent this flaky test failure? @h-mayorquin (you're always the CI king).

See this run for an example: https://github.com/SpikeInterface/spikeinterface/actions/runs/10719779060/job/29724578046?pr=3370

zm711 avatar Sep 05 '24 12:09 zm711

I think that the issue is that at that time there were too many CI jobs in parallel. Let's wait a bit and retrigger

alejoe91 avatar Sep 05 '24 12:09 alejoe91

Yeah sono impaziente. Me dispiace. haha.

zm711 avatar Sep 05 '24 12:09 zm711

Let's keep an eye on this, we have way more runners on neuroconv and this is not a common problem there.

h-mayorquin avatar Sep 05 '24 21:09 h-mayorquin

I've only started seeing it in the past month-ish and only on Windows runners. Just so you have what I have seen.

zm711 avatar Sep 06 '24 13:09 zm711

It might be worth setting a token to remove this as a possibility, the permitted API calls go from 60 per hour unauthenticated to 5000 per hour with a token so should never be an issue once the token is set. I think setting it up is quite simple (famous last words) but needs to be done by the repo / organisation owner.

JoeZiminski avatar Sep 09 '24 10:09 JoeZiminski

How about we try to keep a rough count here in this issue and if it gets high enough we convince Alessio ;)

zm711 avatar Sep 11 '24 12:09 zm711

Yes sounds good!

JoeZiminski avatar Sep 11 '24 16:09 JoeZiminski

Have another rate limit on Windows in my PR #4033.

zm711 avatar Jul 07 '25 12:07 zm711

I have seen this happen 3 more times. What do you think @alejoe91 ? Are we close to doing the token?

zm711 avatar Jul 14 '25 12:07 zm711

Yep let's do that. There should be a built-in GITHUB_TOKEN so we can just set this in the workflow yaml:

env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

alejoe91 avatar Jul 14 '25 13:07 alejoe91