spikeinterface icon indicating copy to clipboard operation
spikeinterface copied to clipboard

Verbose clashing in `recording.save_to_folder` and `job_kwargs`

Open h-mayorquin opened this issue 9 months ago • 7 comments

As in the title,

https://github.com/SpikeInterface/spikeinterface/blob/3864afde8aad572041b4218ebb1d50b2e7a58d6b/src/spikeinterface/core/base.py#L849-L850

There is a verbose in save_to_folder but it also clashes with the save_kwargs which should contain job_kwargs.

Suggestion: drop the verbose in save_to_folder or rename it to print_used_folder if someone wants that functionality.

I swear I read about a similar issue but could not find it. [Edit] Yes, it was a PR not an issue: https://github.com/SpikeInterface/spikeinterface/pull/2602

Also, minimal example:

from spikeinterface.core import generate_recording 

recording = generate_recording(num_channels=3, durations=[10])

from pathlib import Path

folder_path = Path("./test_recording")

job_kwargs={'progress_bar': True, "verbose":True, "n_jobs":2}
recording.save_to_folder(folder=folder_path, verbose=False, overwrite=True, **job_kwargs)   

h-mayorquin avatar May 14 '24 18:05 h-mayorquin