spikeinterface icon indicating copy to clipboard operation
spikeinterface copied to clipboard

Implementing read_spikeglx_event()

Open manimoh opened this issue 1 year ago • 3 comments

manimoh avatar Jan 29 '24 01:01 manimoh

Hi. Thanks for this. This PR is a bit strange because at the momement spikeglx do not handle event in neo. See this line https://github.com/NeuralEnsemble/python-neo/blob/master/neo/rawio/spikeglxrawio.py#L178

Do you plan to handle events on neo side ? DO you know how spikeglx handle events ?

samuelgarcia avatar Feb 26 '24 20:02 samuelgarcia

Hi @samuelgarcia Sorry for the late reply! I did start a PR on the neo repo to implement handling of events. So once that is merged, I guess this can be merged too?

manimoh avatar Mar 23 '24 13:03 manimoh

Fixes #2242.

zm711 avatar Apr 29 '24 18:04 zm711

@alejoe91 can we have this merged now? :)

TheChymera avatar Jun 24 '24 14:06 TheChymera

Yes! Sorry for the delay on this @TheChymera

alejoe91 avatar Jun 24 '24 14:06 alejoe91