Allow plot_probe not to plot on axes, but just return polycollections
Retains previous default behaviour, but adds the option not to plot the collections on an axis, but just to return them. This is useful for incorporating the probe layout into other plots (such as SpikeInterface widgets).
Hi Jake. I understand the need but I find the design a bit complicated and the option not super intuitive. Why not having a clear separated function that create the poly that would used internaly by plot_probe and also by you specific need ? Maybe it is more changes, I don't known. I will try to have a deeper look
Hi Sam, thanks! That makes a lot of sense, I'll work on a refactor
Hi @samuelgarcia, I think this is ready for review - split into a new function as suggested
Codecov Report
:x: Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 89.68%. Comparing base (35d2b19) to head (4604a7e).
:warning: Report is 79 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/probeinterface/plotting.py | 85.71% | 5 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 89.66% 89.68% +0.02%
==========================================
Files 12 12
Lines 1954 1959 +5
==========================================
+ Hits 1752 1757 +5
Misses 202 202
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.