probeinterface icon indicating copy to clipboard operation
probeinterface copied to clipboard

Add automatic probe layout for 3brain/biocam recordings

Open mahlzahn opened this issue 1 year ago • 2 comments

I don’t really know how 'Model' is called inside of the 'ExperimentSettings' for other systems than the 'AccuraV2' and 'AccuraV2_3D' (these are the models which are in the files on ephy_testing_data). Thus, I am guessing that their lowercase versions start with 'stimulo' and 'coreplate'.

Although I changed the default value of the electrode parameters to None, the default for the old Brainwave4 (brw v3.x) format is still 42 μm and 21 μm. Only for the new Brainwave5 (brw v4.x) format the automatic setting is performed.

References for electrode parameters:

  • https://www.3brain.com/products/single-well/hd-mea
  • https://www.3brain.com/products/multiwell/coreplate-multiwell

mahlzahn avatar May 17 '24 16:05 mahlzahn

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.29%. Comparing base (86e5fa4) to head (c0c3292). Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
src/probeinterface/io.py 78.94% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
+ Coverage   88.82%   89.29%   +0.47%     
==========================================
  Files          10       10              
  Lines        1853     1869      +16     
==========================================
+ Hits         1646     1669      +23     
+ Misses        207      200       -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 17 '24 16:05 codecov[bot]

The 4 missing lines in the CodeCov report could only be “fixed” by adding other test files for non-Accura chips that I don’t have (or by weirdly rewritten code that could trick around the “issue”).

mahlzahn avatar May 21 '24 09:05 mahlzahn

Thanks @mahlzahn

Looks good to me! No worries for the codecov. Is it ready to merge?

alejoe91 avatar Jul 03 '24 10:07 alejoe91

Is it ready to merge?

I’d say yes.

mahlzahn avatar Jul 03 '24 11:07 mahlzahn