probeinterface icon indicating copy to clipboard operation
probeinterface copied to clipboard

plot_probe_group -> plot_probegroup

Open zm711 opened this issue 1 year ago • 2 comments

In regards to trying to get more api regularity the object is called a probegroup we don't ever write it as a probe_group. So I would say that to be consistent the plottting function should be plot_probegroup.

zm711 avatar Apr 25 '24 19:04 zm711

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.85%. Comparing base (0a85e41) to head (9eebc20). Report is 74 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   88.82%   88.85%   +0.02%     
==========================================
  Files          10       10              
  Lines        1853     1857       +4     
==========================================
+ Hits         1646     1650       +4     
  Misses        207      207              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 25 '24 19:04 codecov[bot]

If we want full coverage I can add one test where we run the deprecated function.

zm711 avatar Apr 25 '24 19:04 zm711

@alejoe91 this is my bonus api fix, but I'm associating it with this hackathon ;)

zm711 avatar May 29 '24 13:05 zm711