sPyNNaker icon indicating copy to clipboard operation
sPyNNaker copied to clipboard

command sender c code dodgyness

Open alan-stokes opened this issue 4 years ago • 2 comments

Lines 142, 150, 164, 169 dont check for success on the sending of a mc packet.

this is dodgy. given the real reason for repeats was for the external device, not for us to try 5 times without checking at least 1 got throguh.

alan-stokes avatar Jan 12 '21 14:01 alan-stokes

Note that passing a packet through the send routine is no guarantee of success in sending; I think that just means that it will make it in to the router buffer for sending (still a bit better than not sending at all). The router can still drop packets if the other end isn't listening. So sending repeats is still useful even if the send is "successful".

rowleya avatar Jan 12 '21 14:01 rowleya

many many places it can go wrong. but we might as well remove 1 of them if we can

alan-stokes avatar Jan 12 '21 14:01 alan-stokes