Wrong variable in live poisson control code

Open dkfellows opened this issue 6 years ago • 2 comments

https://github.com/SpiNNakerManchester/sPyNNaker/blob/6d4b17dea981455fc49b19312c549bd87608e69e/spynnaker/pyNN/connections/spynnaker_poisson_control_connection.py#L113

Should that be control_label instead of label, which is calculated from label a few lines above?

Nov 13 '19 14:11 dkfellows

Quick fix with https://github.com/SpiNNakerManchester/sPyNNaker/pull/733

Nov 13 '19 15:11 Christian-B

I think however the correct fix is either of.

Check label first time it is used and go pop if wrong.
Check and fix the label every time it is used. Similar to configparser use of the optionxform format.

Nov 13 '19 15:11 Christian-B