sPyNNaker icon indicating copy to clipboard operation
sPyNNaker copied to clipboard

review all abstract classes

Open Christian-B opened this issue 8 months ago • 2 comments

Are they all needed?

Can they be merged or better stacked?

Can they have an empty slots?

Christian-B avatar May 08 '25 08:05 Christian-B

consider replacing some APi with just Union of types. for example SendsSynapticInputsOverSDRAM

Especially as PopulationNeuronsMachineVertex implements the method exactly the same but is not a SendsSynapticInputsOverSDRAM

Christian-B avatar May 08 '25 09:05 Christian-B

Yes there is a case that if you never ask for instanceof an abstract class, you probably don't need it to be abstract... That is a good example, since the type seems to only exist for typing's sake!

rowleya avatar May 08 '25 09:05 rowleya