sPyNNaker icon indicating copy to clipboard operation
sPyNNaker copied to clipboard

Incorrect interface for FixedTotalNumberConnector

Open apdavison opened this issue 7 years ago • 4 comments

FixedTotalNumberConnector should take an argument n, for the number of connections.

In spyNNaker8, FixedTotalNumberConnector is an alias for MultapseConnector, which has an argument num_synapses.

I guess FixedTotalNumberConnector should instead sub-class MultapseConnector, so you can match up the argument names without making a backwards-incompatible change in MultapseConnector.

I also note that MultapseConnector has arguments weights and delays, which have been moved to the SynapseType subclasses in the PyNN 0.8 API.

apdavison avatar Dec 21 '17 16:12 apdavison

I'm going to have a look at this and other connectors in January; thanks for the notes on the interface.

andrewgait avatar Dec 22 '17 11:12 andrewgait

This was covered by https://github.com/SpiNNakerManchester/sPyNNaker8/pull/119. There is still the open issue related to PyNN at https://github.com/SpiNNakerManchester/sPyNNaker/issues/453 that is related to this, so I suggest keeping this issue open until that one is sorted out (which is waiting for NeuralEnsemble/PyNN#555 to be resolved).

andrewgait avatar Apr 18 '18 14:04 andrewgait

Transferring this issue as we have now successfully merged the sPyNNaker8 repository into the sPyNNaker repository.

I believe this particular issue is still yet to be resolved on the PyNN side, though @apdavison likely knows more than I do.

andrewgait avatar Mar 05 '21 12:03 andrewgait

It doesn't look like any fix on the PyNN side has been applied yet so leaving this open.

andrewgait avatar Sep 28 '23 11:09 andrewgait