Sphereon-Opensource
feat: evaluate multi-presentation submissions
This PR is a first step towards supporting multi-presentation submissions in PEX, and partially fixes #149 and also partially fixes https://github.com/Sphereon-Opensource/SIOP-OID4VP/issues/62
This PR only implements support for multiple presentations in evaluatePresentation. If a submission is provided it will make sure presehtation(s) are validated against the submission. If no submission is provided, a submission (that supports multiple VPs) is generated.
In a follow up PR i want to add the (verifiable)PresentationFrom support, but now that we support constructing a valid submission and validating against it, this should be quite straightforward to do. (create VPs, generate submission based on the VPs). But as the PR is already quite large, I didn't want to also add it here.
For our use case, this is actually already enough, as we call verifiablePresentationFrom multiple times for each VP and then 'hack' the submission together from multiple submissions. But it would be great if we can remove that logic and support it natively in PEX.
I added several tests to PEX.spec.ts to cover the new cases and flows
There is a breaking change in that evaluatePresentation now returns an object with presentation property instead of verifiableCredential. We could also return both presentation and verifiableCredential to not make a breaking change. In this case, verifiableCredential would include ALL credentials (from all VPs) and presentation would be the separate presentation (it's the same as the input value). We could also make it a more complex structure (so presentaiton is decoded has verifiableCredential for each VP. Input welcome)
cc @nklomp @cre8
I would prefer when we include a breaking change, we release a new major version. Implementing old approaches will just blow up the code base and I would prefer to have higher major counts than having a lot of redundant code we have to maintain.
A bump to a nest major version would solve the problem we have in #152
I would prefer when we include a breaking change, we release a new major version
Agreed, but we could keep backwards compatibility and not introduce a breaking change, only adding new functionality. If that helps get this PR merged and release sooner, I'm happy to make those changes
Updated based on your initial feedback @nklomp and opened https://github.com/Sphereon-Opensource/PEX/pull/158 for the SD hash change
Hey @nklomp, any chance you can take a look at this PR? We would like to support multi VP presentations in Paradym, and are blocked by this PR (and a follow up PR I will make in SIOP-OID4VP after this is merged and released).
Small nudge on this PR :)
Anything i can help with to make it the reviewing easier? I can remove the breaking changes?
