SeeShark icon indicating copy to clipboard operation
SeeShark copied to clipboard

Published 20 hours ago • verified publisher icon Speykious

add window capture support

Open adryzz opened this issue 2 years ago • 5 comments

Closes #41

  • [ ] x11grab window capture
  • [x] gdigrab window capture

adryzz avatar Oct 30 '22 23:10 adryzz

gdigrab works, although i've encountered a weird issue on the decoder thread where the calculation for how much time to sleep divides by 0 (e.g. decoder.Framerate.num is equal to 0)

image

adryzz avatar Oct 31 '22 00:10 adryzz

Apparently, the decoder frame rate is just a guess from FFmpeg, so when it's 0 we cam just fall back to a default value, as the worst that's gonna happen is a little higher CPU usage

adryzz avatar Oct 31 '22 10:10 adryzz

Apparently gdigrab cannot grab UWP windows...

https://trac.ffmpeg.org/ticket/7718

adryzz avatar Oct 31 '22 14:10 adryzz

i did not forget about this PR, finally gotten around to submitting the ffmpeg patch this depends on, we'll see how it goes from there

adryzz avatar Dec 10 '23 23:12 adryzz

WE ARE IN LETS GOOOOOOOOOOO

https://github.com/FFmpeg/FFmpeg/commit/d7ac7101ee8c70a253f7caf400d9ae3870880d7f

ill finally finish this pr lol

adryzz avatar Dec 17 '23 19:12 adryzz

welp it's definitely in mainline by now, time to update and stuff

adryzz avatar Apr 15 '24 11:04 adryzz

Seems like I got the time to make a complete rewrite PR before this one got updated. xD I think it's best I close this one in favor of #51. Though I'm sure we can reuse all the interop code for GDI support.

Speykious avatar May 20 '24 09:05 Speykious