Spencer Torres

Results 21 comments of Spencer Torres

My suggestion based on your points: 1. default/undefined value can be "Not reviewed" 2. `warnings: [...]` can be "Reviewed, warnings identified" 3. `warnings: []` can be "Reviewed, no warnings" The...

looks like CI was broken on master when I pulled. Updated again

Looks like master is consistently failing to run, however I did fix a new one-line lint issue related to test code added in this commit. Updated *again*

Try splitting the values in the URL Cloudflare gives you: The **server address** would be `api.cloudflare.com` and then the **HTTP URL Path** would be the part after the host: `client/v4/accounts/....analytics...`....

Good idea with the ports, I looked at the other plugin's UI and it seems like Cloudflare would be exposing `443` in this case. In the network log screenshot you...

Still investigating this using my own Cloudflare account. This is the error it's returning on the plugin backend: Raw error: ``` {"@level":"error","@message":"clickhouse: unsupported column type \"\\n\\t\\t{\\n\\t\\t\\t\\\"name\\\": \\\"timezone()\\\",\\n\\t\\t\\t\\\"type\\\": \\\"String\\\"\\n\\t\\t}\\n\\t],\\n\\n\\t\\\"data\\\":\\n\\t[\\n\\t\\t{\\n\\t\\t\\t\\\"timezone()\\\":\"","@timestamp":"2024-02-28T01:49:55.600261-05:00"} ``` Manually...

Linking the actual code for future reference: https://github.com/ClickHouse/ClickHouse/blob/bebed0598d968e01fd806c22ffaa622df5b50778/src/Storages/Kafka/StorageKafka.cpp#L863-L868

Good find. This is a case I failed to identify when I reviewed the first PR, [although I was *suspicious*](https://github.com/grafana/clickhouse-datasource/pull/785#issuecomment-2029949277). We can add some unit tests for this and maybe...

If it wasn't for the requirement of overriding the interval, I would suggest using the time interval macros: | Macro | Description | Output example | |----------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------------------------------------------------------------------| | *$__timeInterval(columnName)* |...

> Does the `$__timeInterval` macro meet these requirements? `$__timeInterval` uses the "AUTO" interval from the panel. In this case they want to use their own interval variable from the dashboard,...