Vincent Rouillé

Results 44 comments of Vincent Rouillé

@bluejekyll Can you take a minute or two to give me access to the foundationdb-sys and foundationdb-gen crates on crates.io.

Just got access to foundationdb-sys/gen :)

Great work :) For the bindingtester, you can add the test to https://github.com/Clikengo/foundationdb-rs/blob/master/scripts/run_bindingtester.sh so the CI runs it. test-name is directory I think

Hi, Nice work 👏 About the Send issue, I see 2 ways to try to fix it : 1. Very simple: maybe `FdbValuesIter` and `FdbValue` should contains an `Arc`. Then...

Well the binding tester failed, so this might be breaking current code.

I haven't yet had time to figure out what this commit breaks to cause the binding tester to fail.

The change you made is correct. I also can't figure out a way to write this commit without a breaking change.

Well maybe decode_from should not try to decode the whole set of bytes for some types. (ie. Element) Your code could be simplified to: ```rust TupleUnpack => { let data:...

Differentiating between decode and decode_from will minimize the impact but it's still a breaking change due to the fact data are now encoded according to the official spec (decoding allows...

The 0.4 parser will decode what was `(a, b)` as `((a, b),)`. In the 0.3 branch depending on how you manipulate tuple, they might be nested at level 0 or...