BloodHound icon indicating copy to clipboard operation
BloodHound copied to clipboard

chore(cmd/ui): fetch dagrejs via HTTPS

Open 42LoCo42 opened this issue 1 month ago • 4 comments

Build systems which don't use the yarn cache can't fetch git dependencies via ssh if no valid credentials are found, e.g. when the build is run in a sandbox.

Description

This PR replaces the SSH URL for dagrejs in cmd/ui/package.json with an equivalent HTTPS URL, thus allowing build systems to fetch dagrejs without requiring access to SSH credentials.

Motivation and Context

Resolves https://github.com/SpecterOps/BloodHound/issues/2096

This change is required to build BloodHound with build systems that don't use the yarn cache included in this repository and also run builds in a sandbox with no access to SSH credentials.

How Has This Been Tested?

I'm packaging BloodHound for Nix in https://github.com/NixOS/nixpkgs/pull/461387. There, I currently use a patch roughly equivalent to this PR in order to fix the build issue. With it, the BloodHound package builds successfully.

On a system with Nix installed & Flakes enabled, the package can be built like this:

nix build github:42loco42/nixpkgs/add-bloodhound-ce#bloodhound-ce

Types of changes

  • Chore (a change that does not modify the application functionality)

Checklist:

  • [x] I have met the contributing prerequisites
    • Assigned myself to this PR
    • Added the appropriate labels
    • Associated an issue: https://github.com/SpecterOps/BloodHound/issues/672
    • Read the Contributing guide: https://github.com/SpecterOps/BloodHound/wiki/Contributing
  • [ ] I have ensured that related documentation is up-to-date
    • Open API docs
    • Code comments (GoDocs / JSDocs)
  • [ ] I have followed proper test practices
    • Added/updated tests to cover my changes
    • All new and existing tests passed

Summary by CodeRabbit

  • Chores
    • Updated project dependency configuration for improved build environment compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

42LoCo42 avatar Nov 22 '25 09:11 42LoCo42