taxonworks icon indicating copy to clipboard operation
taxonworks copied to clipboard

Published 20 hours ago • verified publisher icon SpeciesFileGroup

Zeitwerk mode

Open LocoDelAssembly opened this issue 3 years ago • 4 comments

We might need to consider prioritizing changing our loader to Zeitwerk. Besides occasionally having to patch loading (like in https://github.com/SpeciesFileGroup/taxonworks/commit/7768b7e3f11e38ef8e2dbd167f99416026f605d2), it will be mandatory Rails 7

LocoDelAssembly avatar Dec 09 '21 11:12 LocoDelAssembly

We definitely need to do this, it will also help cleanup our autoload.

Can we start/work on it in a Rails 7 branch?

mjy avatar Dec 09 '21 19:12 mjy

You think we should go all the way now and not just have zeitwerk working with current rails?

LocoDelAssembly avatar Dec 09 '21 19:12 LocoDelAssembly

I guess I'm predicting that the refactor required will be large enough that it makes sense to undertake it when we also move to 7, but I could be wrong. I'm fine with a seperate branch tackling the problem pre 7.

mjy avatar Dec 09 '21 21:12 mjy

Related: https://github.com/SpeciesFileGroup/taxonworks/issues/2981

@LocoDelAssembly let's make 2 PRs for now. This alone, and 7 alone, and see where it goes from there?

mjy avatar May 08 '22 16:05 mjy