taxonworks icon indicating copy to clipboard operation
taxonworks copied to clipboard

Bibliography preview should render italics

Open mjy opened this issue 4 years ago • 5 comments

When I filter sources, and I click on Download formatted, then the preview of the download should render out the italics markup.

mjy avatar Oct 28 '20 17:10 mjy

Currently it seems like markup for italics in titles is included in the preview if the title was saved with italics in the title:

image

The actual rendering is done by citeproc here: https://github.com/SpeciesFileGroup/taxonworks/blob/8876554b3994b0b2cd5a73e38e207bd6bbd0635f/app/models/source/bibtex.rb#L839-L843

If I set the format to html or set cp.engine.format = 'html' as in the docs, I get the following instead: image Note the author '&' has been turned into & and italic markup has been added to the journal name and journal volume.

Are either of those what you had in mind, or were you thinking something else?

kleintom avatar Jan 05 '24 17:01 kleintom

@proceps

jlpereira avatar Feb 26 '24 20:02 jlpereira

I can't remember what I was thinking back then, but my comment makes it seem like I never considered that maybe you meant you literally wanted the preview to display text tagged with italics markup as italics, without the markup, in the preview.

kleintom avatar Feb 26 '24 20:02 kleintom

I talked with Dimitry the other day, he told me that we shouldn't display HTML tags there

jlpereira avatar Feb 26 '24 20:02 jlpereira

Yes, this was a comment from a few users that they to not want to see html tags there. At the same time it was noted that for some reason, TW style is not listed as an option for the text rendering.

proceps avatar Feb 26 '24 20:02 proceps