taxonworks
taxonworks copied to clipboard
SpeciesFileGroup
Pinboard - Sources
When I delete numerous sources from the pinboard, some of them are not deleted from the first attempt. And email error notification are fired. The sources are deleted from the second or third attempt.
@LocoDelAssembly if you have a chance remind me where you handled the thread lock retries? Seems to be related.
https://github.com/SpeciesFileGroup/taxonworks/commit/8544ef9a960b0227d54d59299659792cbb225d04 <- This is the commit, but no so sure it can actually be related, I think you have to explicitly opt-in retry behavior.
El mar., 1 sep. 2020 15:10, Matt [email protected] escribió:
@LocoDelAssembly https://github.com/LocoDelAssembly if you have a chance remind me where you handled the thread lock retries? Seems to be related.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SpeciesFileGroup/taxonworks/issues/1690#issuecomment-685043221, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGCXNLNSAUSS4AU57K4ZFDSDU2LFANCNFSM4QRHCFCQ .
This is almost certainly related to the after_save in PinboardItem using update and update_all rather than the non-callback equivalents. Will test.
Not fully resolved when a Source is removed.
Also requires batch create by type calls.