SpecFlow icon indicating copy to clipboard operation
SpecFlow copied to clipboard

Finish implementation of cucumber-messages

Open SabotageAndi opened this issue 3 years ago • 0 comments

We are currently supporting a first set of the messages of cucumber-messages. Since implementation of it, cucumber-messages changed a lot (changes messages, new messages).

Goal of this issue is, to bring the cucumber-messages implementation on the latest version and implement all messages.

Steps to do before we can implement the rest of the cucumber-messages:

  • [ ] #2498
  • [ ] add .NET Gherkin parser into CI- Build of the cucumber monorepo
  • [ ] change the AST of the Gherkin parser to the cucumber-messages AST classes (WIP at https://github.com/SabotageAndi/cucumber/tree/use-cucumber-messages-in-gherkin-dotnet)
  • [ ] update Gherkin parser in SpecFlow Currently, we are inheriting the AST classes in SpecFlow and enhance it with additional information (like https://github.com/SpecFlowOSS/SpecFlow/blob/master/TechTalk.SpecFlow.Parser/SpecFlowFeature.cs#L8). As the cucumber-messages AST classes are now sealed, we can't do this anymore. So we need to create complete wrappers around the AST classes.
  • [x] #2499

It can be, that the code-behind file generation has to be adapted to the new classes.

What I am unsure about is, what is to do for the Pickle cucumber-messages. SpecFlow doesn't do anything with Pickles yet. Also, I am unsure about the pickles implementation in the Gherkin parser.

When this all is implemented, starting to add the missing cucumber-messages should be possible.

SabotageAndi avatar Sep 09 '20 06:09 SabotageAndi