elixir-sparkpost icon indicating copy to clipboard operation
elixir-sparkpost copied to clipboard

Add support for OAuth 1.0 or decouple HTTP client from base lib

Open mje113 opened this issue 9 years ago • 3 comments

Our SparkPost server is sitting behind an OAuth 1.0 gateway on our internal network. While adding OAuth support would probably be a heavyweight approach--I wonder if there would be some way to decouple the specific HTTP client being used, for a more bring-your-own approach?

mje113 avatar Mar 03 '16 17:03 mje113

That's an interesting idea @mje113 - we actually do this type of de-coupling with our PHP library. It's bring your own HTTP lib. Do you have any ideas around what that might look like architecturally? Is there a specific lib you have in mind that you'd want to use?

richleland avatar Mar 04 '16 15:03 richleland

@mje113 Jumping in here because I've been working on getting SparkPost moved over to HTTPoison on top of Hackney over HTTPotion on iBrowse (see #12). We've also discussed using dependency injection with on #13 which in theory would allow you to bring your HTTP communication layer.

DavidAntaramian avatar Mar 12 '16 03:03 DavidAntaramian

@DavidAntaramian Cool, I'll check that out. I managed to side-step my OAuth requirement for the time being so this issue fell off my immediate radar.

mje113 avatar Mar 15 '16 12:03 mje113