Changing Group Type settings in Check-in Configuration deletes Inherited Group Type setting

[leahjennings]

Description

When a Group Type has an "Inherited Group Type" setting, that setting is deleted if the Group Type is edited on the Check-in Configuration page.

We have created a parent group type with a bunch of group attributes that get inherited to a few child group types. We have "lost" that inheritance multiple times without changing the group type explicitly. We finally nailed down the issue to when you change the group type in the Check-in configuration page.

Actual Behavior

When editing a Group Type from the Check-in Configuration page, the Inherited Group Type is deleted.

Expected Behavior

I would expect to be able to edit a Group Type on the Check-in configuration page without it affecting what is set in the Inherited Group Type field.

Steps to Reproduce

• On the demo server, navigate to Admin Tools > General Settings, then click on Group Types

• Click the + to create a new Group Type

• Set the Inherited Group Type to Serving Team, then click Save

• Back on the list of Group Types, click to edit Volunteer Check-In

• Add the new Group Type as an Allowed Child Group Types, then Save

• Go to Admin Tools > Check-In, then click on the Volunteeer Check-In area

• In the Areas and Groups section, click on the newly added Group Type (in this example, it's Inherits Serving Team

• Change the Check-in rule to Already Belongs then Save

• Navigate back to Admin Tools > General Settings, then click on Group Types

• Click on the new group type (Inherits Serving Team in this example)

• Expand General

• Notice how the Inherited Group Type setting is now empty

Issue Confirmation

• [X] Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• [X] Reproduced the problem on a fresh install or on the demo site.

Rock Version

Rock McKinley 16.6 (1.16.6.9), Rock McKinley 16.4 (1.16.4.4)

Client Culture Setting

en-US