Rock icon indicating copy to clipboard operation
Rock copied to clipboard

Obsidian Registration Allowing Transactions After Reaching Maximum Attendees

Open SkellyRen opened this issue 10 months ago • 2 comments

Description

Hillside Christian Church reached out to us this week and reported that they had a waitlisted camp registration pay the downpayment even though they had been waitlisting registrations for a couple of days at that point. I found that the Obsidian Registration Entry block will allow a transactions to happen without after reaching the Maximum Attendees if the registration was already in process in an open browser window.

Actual Behavior

If a registration is in process after hitting the maximum amount of attendees (both with and without a timeout length) it will display the Payment Summary allowing for a payment transaction to be ran. With testing I have discovered that this will happen with or without a waitlist enabled.

Here is a screen shot of the registrations showing two waitlisted registrations having a negative balance because they were able to make a transaction during their registration:

image

Expected Behavior

When the registration instance hits the maximum attendees with a waitlist the registrar should be presented with the Payment Summary page displaying that they will be added to the waitlist with $0.00 cost if a waitlist is enabled or displaying that the event is full if the registration does not have a waitlist enabled.

image

Steps to Reproduce

  • Create a Registration Instance with a maximum amount of attendees set.
  • Have a Registration in process to test after hitting the maximum attendees amount and finish the registration.

Issue Confirmation

  • [X] Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • [X] Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

16.4

Client Culture Setting

en-US

SkellyRen avatar Apr 10 '24 20:04 SkellyRen

Thanks @SkellyRen

mcnoodles avatar Apr 15 '24 21:04 mcnoodles

We are also experiencing this issue on our system. We are on v16.4 and the en-US Culture Setting.

jdwrhodes avatar Jun 17 '24 19:06 jdwrhodes

@SkellyRen @jdwrhodes We addressed this issue in a few different commits that span v16.6 and v16.7 (some didn't make the cutoff point). Below is a summary of the modifications made:

The first change resolves the issue where registrations incorrectly included charges for individuals on the waitlist. The second change specifically addresses updates to the waitlist messaging in the final confirmation step.

Please let us know if you have any questions or concerns with the above changes.

joshuahenninger avatar Jul 10 '24 19:07 joshuahenninger