Attendance: Check-in Configuration Streak Type Rebuild does not include all groups

[azturner]

Description

When rebuilding a streak type that has a linked activity of "Attendance: Check-in Configuration" it only includes groups that have just one (or zero) areas (group types) in their parent hierarchy.

https://github.com/SparkDevNetwork/Rock/blob/develop/Rock/Model/Engagement/StreakType/StreakTypeService.cs

Actual Behavior

When rebuilding a streak type that has a linked activity of "Attendance: Check-in Configuration" it only includes groups who have just one group type in their parent hierarchy.

For example, rebuilding this streak type:

Only includes people from the last four groups in this screenshot:

It does not include people from the other groups, because those groups have more than one parent group type under the check-in configuration area.

Expected Behavior

People from all the groups are included.

Steps to Reproduce

• Create check-in config with groups that have more than one parent group type ("Area")
• Add attendance data for people in those groups
• Create a streak type based on the check-in config
• Rebuild the streak type with start date prior to the attendance
• Note that the streak does not include people who checked into groups with more than one parent area.

Issue Confirmation

• [X] Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• [X] Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

v15.3

Client Culture Setting

en-US

[chead4]

@azturner Hi David - I've been unable to recreate this issue on v16.3. Please confirm if you are able to recreate this issue on the demo site.

[Luke-Potter]

@chead4 I just confirmed this on the rockrmsdemo.com site. https://rockrmsdemo.com/people/streaks/type/2 https://rockrmsdemo.com/page/201?CheckinTypeId=1038

I check in the Foster Family into the Parent 1 > Parent 2 ? Checkin Area! group, but they do not show up in the Streak.

I check in Alisha Admin into the One Level Deep > 1 Parent Group group & she appears in the Streak.

[chead4]

@Luke-Potter Thanks for jumping in and helping out to recreate this issue Luke. I have added the label: Status: Confirmed as well as added your comments to our internal issue.