One-Time Schedules Not Being Inactivated on Refresh

[taylorbrooks]

Prerequisites

• [x] Put an X between the brackets on this line if you have done all of the following:
  • Did you perform a search at https://github.com/issues?q=is%3Aissue+user%3ASparkDevNetwork+-repo%3ARock to see if your bug or enhancement is already reported?
  • Can you reproduce the problem on a fresh install or the demo site?
  • Did you include your Rock version number and client culture setting?

A Picture Is worth a Thousand Words

Description

Rock has the concept of "one-time" recurring transactions. I think this is primarily used when a donor wants to create a future one-time gift.

Once that gift occurs and the recurring transaction is processed, the schedule still shows as active in Rock.

This has the potential to skew report data on "how many active recurring donations do we have?", "how much recurring donations are we processing?", etc.

Ideally, when a "one-time" recurring transaction is processed, the schedule should be inactivated. That way you don't have orphaned transactions where no future operation should be expected.

Let's say, as an admin, you look at an individual "one-time" recurring transaction that still appears in an "active" state. If you click the "Refresh Now" button, you will get an error notice that says, "Schedule is inactive" and the label on the top right of the transaction details will say "Inactive". However, if you refresh the page, the schedule is still active and the state of the database did not actually change.

Expected behavior:

When I click "Refresh Now" on a historical, one-time recurring FinancialScheduledTransaction, I expect the ScheduledTransaction to be marked as Inactive, because that is what the UI says.

Actual behavior:

When I click "Refresh Now" on a historical, one-time recurring FinancialScheduledTransaction, the UI says shows "Schedule is inactive", but the IsActive column was not changed.

Versions

• Rock Version: 13.x
• Client Culture Setting: en-us