Giving Analytics is Not Respecting Advanced Options: Tax Deductible

[jsw-austin]

I'm submitting this on behalf of Church on the Rock, St. Peters, MO.

Prerequisites

• [ ] Put an X between the brackets on this line if you have done all of the following: [x] Did you perform a search at https://github.com/issues?q=is%3Aissue+user%3ASparkDevNetwork+-repo%3ARock to see if your bug or enhancement is already reported? [x] Can you reproduce the problem on a fresh install or the demo site? [x] Did you include your Rock version number and client culture setting?

A Picture Is worth a Thousand Words

I'd expect that when the account has tax deductible false:

And there's a transaction to that account like this:

and then when Tax-Deductible is checked on Advanced Options in Giving Analytics that the gift which isn't tax-deductible would be excluded, whereas here it's included:

Description

When someone has a transaction to a Financial Account that is not tax deductible, it still shows up on Giving Analytics even if you check Tax-deductible on the Advanced Options.

Steps to Reproduce

1. Go to Financial Batches and Create a batch
2. Add a transaction for the account "event registration" (ideally to someone that doesn't already have a transaction - like I did to Paul Smith)
3. Go to Giving Analytics and pick a date range that will include the transaction you just created.
4. Click on Advanced Options
5. Make sure Tax-Deductible is Selected
6. Click Update
7. Click Details
8. See that the transaction with the Event Registration is included

Expected behavior:

I'd expect that if I choose Tax-Deductible that only transactions for Tax-Deductible accounts would be included - that accounts where Tax-deductible is set to false would be excluded

Actual behavior:

When Tax-Deductible is selected, non tax deductible accounts are included.

Versions

Rock Version: Rock McKinley 13.2 (1.13.2.2)

Client Culture Setting: en-US

Also tested on Rock Solid Church demo with same results:

Rock Version: Rock McKinley 13.6 (1.13.6.1)

Client Culture Setting: en-US