Rock
Rock copied to clipboard
SparkDevNetwork
Communication Medium Pill Style Inconsistent
Prerequisites
- [X ] Put an X between the brackets on this line if you have done all of the following:
- Did you perform a search at https://github.com/issues?q=is%3Aissue+user%3ASparkDevNetwork+-repo%3ARock to see if your bug or enhancement is already reported? Yes
- Can you reproduce the problem on a fresh install or the demo site? Yes
- Did you include your Rock version number and client culture setting? Yes
A Picture Is worth a Thousand Words
Did you know you you can simply copy and paste an image below? Please do that. It really helps us quickly understand the problem.
Page Style with Email Pill selected:
Page Style with SMS Pill selected:
Description
The page styles change when moving between the Communication Medium selected pill.
Steps to Reproduce
- Go to 'https://rock.rocksolidchurchdemo.com/page/495?CommunicationId=1'
- Change the communication medium selected pill
- As you move between the mediums, the page styles will change (page title, breadcrumbs, block title, pill text, etc.). On our system we have more than 2 mediums so it is more obvious that the Email pill applies a different style than the other pills.
Expected behavior:
The style should stay consistent when moving between communication mediums.
Actual behavior:
The Email pill applies a different style than the other pills.
Versions
- Rock Version: 13.2
-
Client Culture Setting: en-US
This appears to only affect Simple Communication, the wizard based method uses radio buttons and a different page layout.
Also, this may be fixed as of 13.3.
The issue is that the CSS is spilling out of the Summernote editor and effecting the page. We have a couple of ideas on how to fix it, but none of them a super-great.
Ah, I see we have an empty email as the default for our Simple Communication editor. Once I pick a Template, the bug gets triggered. That would explain the difference!
Does this bug also impact the Communication Entry block showing and the Communication Detail block not showing? On our test system with 13.3, we see both blocks defined on the page (same as our production system with 12.6), but the Communication Detail block doesn't show content whereas the Communication Entry block is shown like we are creating a new Communication with the contents of the selected communication from Communication History.
Production (12.6):
Test (13.3):
I tried to replicate this on rocksolidchurchdemo.com but it appears the site is not working at the moment. I can log in but nothing displays other than the header:
Sorry for not being more clear. In your response above you mentioned "The issue is that the CSS is spilling out of the Summernote editor and effecting the page."
I was trying to ask if this issue could be the cause of the Communication Detail block on that page not displaying any data in our v13.3 test system. Would the CSS issue just cause formatting issues or could it cause a block to not display its contents?
@kkiserGH I don't believe the Communication Detail block would have the same problem as the markup for showing the communication is inside of an iframe.
@kkiserGH the inconsistency is caused by CSS style overwritten by the EmailHeader template.
This section of code overwrites the bootstrap header element style.
I guess we need to update the DefaultValue for EmailHeaher in the Attribute DB table.
The CSS bleeding out of SummerNote is not something we can cleanly fix as it's not in an iframe. Our plan is to use a different WYSIWYG editor in our next gen re-write. This is planned for v17. Leaving this open as it still is technically an issue. Will close when new block is completed.
We've change our process how how we process issues that are for external components that we are not able to update ourselves. I'm closing this because it is in a external component. That said we are currently working on a new Obsidian block to replace this one and we'll use a different component for that one.