Event Registration "Process New Payment" breaks "Add Manual Payment"

[JimMichael]

Description

When using the internal site to process an Event Registration payment, clicking Process New Payment and then cancelling breaks the UI for the Add Manual Payment function.

Steps to Reproduce

1. Go to an Event Registration instance that has a cost

2. Add a Registered By and Registrant

3. Click The Payments tab

4. Observe that if you click the Add Manual Payment button, you get the expected UI where you can add an amount, summary, currency type etc, and Submitting this form creates a transaction on the Person's record.

5. But cancel that form to get back to the Payments form and instead click Process New Payment. Now observe a similar form, but this time there is a Next button and clicking that takes you to the expected Payment Information screen where you can enter CC info.

6. Up to this point, everything is normal and as-expected, but now click Cancel on the Payment Information screen to get back to the Payments form.

7. Now click Add Manual Payment again, and observe that instead of seeing the (exact) UI you saw in Step 4, you see the Expected Payment Information form, but with a Next button instead of Submit

and even weirder, if you click Next from here, you end up at the credit card entry screen that you should only see when doing Step 5 (Process New Payment) AND the act of clicking Next here actually SAVES the manual transaction, as if in fact it IS the Submit button, but labeled incorrectly... but by doing so you still end up on an unexpected and confusing credit card entry form.

Expected behavior:

Clicking Process New Payment on an internal Event Registration payment (and then canceling it) would not interfere with the Add Manual Payment option.

Actual behavior:

Both forms seem to share common form controls and interact with each other in unexpected ways when you cancel one and select the other.

Versions

• Rock Version: 12.6

[cwomack]

@JimMichael, what payment gateway were you using within this Registration Template?

[JimMichael]

NMI

[dataCollegechurch]

confirmed using Rock 12.7 and NMI as well.

[ethan-sparkdevnetwork]

@JimMichael I tested this in 16.1 and it is working correctly after the overhaul of the payments tab for hosted gateways in 15.0. I noticed the cancel buttons were missing for the payment options so I added those in 16.1 (via https://github.com/sparkdevnetwork/rock/commit/371e076654fad3d1a82edd046706ebe3bcc3a623). Let me know if you still see a problem.