WebCord icon indicating copy to clipboard operation
WebCord copied to clipboard

Noise suppression not working

Open a0193143 opened this issue 2 years ago • 5 comments

Acknowledgements

  • [X] I have checked that there is no other issue describing the same or similar problem that I currently have, regardless if it has been closed or open.

  • [X] This bug affects Discord website.

  • [ ] This issue is confirmed to be reproducible when WebCord is packaged on at least all three latest supported Electron major releases.

  • [X] This issue is reproducible in Chrome, Chromium or any Chromium-based browser, e.g Brave or Edge (please write in Additional Context which browser you have used if it is neither Chrome nor unmodified Chromium).

  • [ ] There are no fixes done to master which resolves this issue.

  • [ ] My issue describes one of the unstable and/or not fully implemented features.

  • [ ] I have found a workaround to mitigate or temporarily fix this issue in affected releases (please write it in Additional context section below).

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

28.0.0

Application version

4.6.0

Bug description

Both Krisp and Standard mode of noise suprression not working, but official Discord app is fine. Noticed this also not work in both Chromium and Firefox.

Additional context

OS: EndeavourOS with XWayland and Wayland tried. Hardware: Surface Go 3 (using built-in Mic)

As screenshot shows, the volume bar (noise at the moment) in official app (left) is almost 0 compared to Webcord (right). Screenshot_20231218_182308

a0193143 avatar Dec 18 '23 10:12 a0193143

Noticed this also not work in both Chromium and Firefox.

Pretty much self-explainatory why.

SpacingBat3 avatar Dec 18 '23 21:12 SpacingBat3

Also flagging this as Wayland-specific issue for now, since I have no idea if it is a quirk with Wayland or not (possibly not, but as long as nobody reports this on X11, I'll keep issues flagged like that).

SpacingBat3 avatar Dec 18 '23 21:12 SpacingBat3

This isn't Wayland related issue, I could reproduce on Windows as well. Maybe Discord use specific API for noise suppression?

a0193143 avatar Dec 20 '23 08:12 a0193143

Happens with me on X11, too. I've never experienced noise suppression working on any platform. Never worked on web version of discord so there's that.

I get around it by applying noise suppression via Pipewire.

ZenitH-AT avatar Dec 20 '23 11:12 ZenitH-AT

Maybe Discord use specific API for noise suppression?

That is very likely to happen, in fact I suspect they're using their own (native) Node module for handling the audio. Take a note it is proprietary for now and WebCord for audio management relies only on Chromium logic (which is why bugs and limitations that occur in Chromium but not in Discord can happen with WebCord as well).

SpacingBat3 avatar Dec 20 '23 12:12 SpacingBat3