Michael Förderer comments

Results 489 comments of


                                            Michael Förderer

Confluence.is_page_content_is_already_updated() should not emit a warning if content is the same

Please create a PR for this.

[Confluence] get_page_child_by_type without pagination parameters results in MissingSchema exception

It seems that this depends on the used endpoint. With #990 this was fixed.

object Jira.issue_transition('key-123','151') - getting Exception has occurred: TypeError issue_transition() missing 1 required positional argument: 'status'

Please read the docs carefully. You first have to create a Jira instance and on this instance you call the methods.

[Confluence] better documentation required

You should use a Editor which is aware of the inline documentation.

[Confluence] better documentation required

The arguments are documented inline (can be more 😄): https://github.com/atlassian-api/atlassian-python-api/blob/f14682a6b25f0b392bac672f7da1b2287751e1a2/atlassian/confluence.py#L1479-L1504 This is used for example in VS Code: The used API, whiche returns you're error message, is documented [here](https://developer.atlassian.com/cloud/confluence/rest/api-group-content/#api-wiki-rest-api-content-id-put)

Shouldn't trying to delete a non-existent Confluence space raise an ApiNotFoundError?

I think raising an error is sufficient. To check if a page exists you should use https://github.com/atlassian-api/atlassian-python-api/blob/1b5cf5eee871ab44ce31c1dd71f7452a67d186b2/atlassian/confluence.py#L88.

Shouldn't trying to delete a non-existent Confluence space raise an ApiNotFoundError?

As described in the comment the reason is ambiguous. From the docs: ``` 404 Returned if there is no content with the given id, or if the calling user does...

Shouldn't trying to delete a non-existent Confluence space raise an ApiNotFoundError?

`ApiNotFound` is wrong, it could also be `ApiPermissionError`. What's wrong to catch an `ApiError`?

Shouldn't trying to delete a non-existent Confluence space raise an ApiNotFoundError?

And the API can't distinguish between the two cases because both result in a 404. `ApiError` is the result of this 404 and nothing changes if we name it `ApiNotFoundOrPermissionDeniedError`.

Shouldn't trying to delete a non-existent Confluence space raise an ApiNotFoundError?

Please read the API docs (https://docs.atlassian.com/ConfluenceServer/rest/7.17.2/#content-delete) this can't be distinguished here. Other APIs like the GET (https://docs.atlassian.com/ConfluenceServer/rest/7.17.2/#content-getContent) specify only one error reason.