Ethan Hunter

Results 41 comments of Ethan Hunter

> Good find! I see you're referring to discovery/manager.go. I assume you're running Prometheus with --enable-feature=new-service-discovery-manager. Ah, we do not use `--enable-feature=new-service-discovery-manager` and I didn't realize `discovery/manager.go` was gated behind...

> A similar problem has already been discussed in https://github.com/prometheus/prometheus/issues/8768, and a patch was merged via https://github.com/prometheus/prometheus/pull/10948 Ah, great find! Unfortunately the 2-level select in #10948 cannot work without some...

As a proof of concept/demonstration of the issue, I've updated #13677 so that `TestHangingNotifier` sends values on the syncCh consistent with the "real" way the discovery package does it. I've...

> I added a "cleaner" reproducer for this here https://github.com/prometheus/prometheus/pull/14174, if you could take a look. Thanks taking a look at this! And thanks again for the reproduction test, it's...

Hi! This is an interesting change. I can definitely see the value. It's also a pretty significant behavior change, so we'll want to make sure it's something we want to...

I like this idea, but I'm wondering if we should have a more generic implementation. I'm less familiar with the Jira integration than I should be, honestly. Are there any...

> from my experience what should be configurable (whats most relevant to users) is the summary and description. customfields, priority and other stuff is more static in most cases. (for...

> Can you share some numbers so we can get a sense of how big an improvement this is? Yes, I've attached some graphs which show the performance improvements we've...

> Just to learn more about how you are using Alertmanager, as it helps us improve the software, it sounds like from what you've written you do a lot of...

Is there anything else I can provide here to help this one move forward?