Amrit Rathie

Results 27 comments of Amrit Rathie

#### Steps to Reproduce ``` $ git clone https://github.com/Spaceface16518/wasm-pack.git Cloning into 'wasm-pack'... remote: Enumerating objects: 5449, done. remote: Counting objects: 100% (13/13), done. remote: Compressing objects: 100% (12/12), done. remote:...

Confirmed to not just be a quirk of my computer? ``` $ docker run -v $PWD:/app/ -t rust bash -c "while [ \$? -eq 0 ]; do cargo run --release...

I could not make valgrind pick up the segfault so I used the core dump + gdb post-mortem strategy and came up with this backtrace. ``` #29 0x0000556385f15124 in wasm_pack::manifest::Crate::check_wasm_pack_latest_version...

That narrows it down the the call to curl from `src/manifest/mod.rs`, which means this is likely a C issue, not a rust issue. https://github.com/rustwasm/wasm-pack/blob/d46d1c69b788956160deed5e4e603f4f2780ffcf/src/manifest/mod.rs#L242-L261

This could be related to https://github.com/curl/curl/issues/6898 since the segfault happens after the help message is printed (and presumably after the request happens) as curl is being cleaned up.

Yeah when I actually read the issue in detail it seems less likely to be to same problem. It was just the first issue that mentioned a segmentation fault and...

The last entry in the backtrace leads to the construction of an `Easy2`. https://github.com/rustwasm/wasm-pack/blob/d46d1c69b788956160deed5e4e603f4f2780ffcf/src/manifest/mod.rs#L245 I made another backtrace to investigate further (gave up on redaction lol. No use anyway.) ```...

Going further up the trace leads us to `OPENSSL_init_ssl()`. A similar function exists in `libcurl`, by the name of `Curl_init_ssl()`, which _is_ called by `global_init`. The missing link is in...

On a separate note, I see absolutely no reason for this tool to use curl at all. Considering this is the only use of curl in the codebase (excluding tests),...

The linked post provides a good solution for when the sets are the same size. Is there any way to extend the solution to n ∩ m sets? Specifically, I...