utilities icon indicating copy to clipboard operation
utilities copied to clipboard

DRY: Remove unused createNPPixArrayDist.

Open WillieMaddox opened this issue 7 years ago • 2 comments

This function is also a copy of createDistanceTransform.

WillieMaddox avatar Apr 22 '17 15:04 WillieMaddox

@WillieMaddox

Thank you for the pull request.

We still use that command in a couple of other places. Is it possible to instead push a change that prints that The function will be deprecated in the next release and then call the createDistanceTransform from inside?

Thank you,

dlindenbaum avatar Apr 26 '17 13:04 dlindenbaum

That's strange. When I do, grep -ir createNPPixArrayDist I only see it in one place, utilities/python/spaceNetUtilities/labelTools.py:def createNPPixArrayDist(rasterSrc, vectorSrc, npDistFileName='', units='pixels'): In any case, I'll submit another PR with the deprecation notice and redirect.

WillieMaddox avatar Apr 27 '17 15:04 WillieMaddox