SpacemanDMM

SpacemanDMM copied to clipboard

Parser chokes on paths containing "operator"

1

It is perhaps unwise to include `operator` in a path, but BYOND accepts it. ``` /datum/operator /datum/operator/proc/test() ``` This emits a warning that the proc is relatively-pathed, and confuses the...

Exxion

environment parser fails silently on consts that conflict with builtins

1

For 515 forward compatibility, I have had these five consts declared in a block of `#if DM_VERSION < 515` in [_version.dm#L66](https://github.com/Baystation12/Baystation12/blob/6389aada31c6f666f45c5a390f4ba47b02079932/code/_version.dm#L66). I also added these to suite's builtins.rs in https://github.com/SpaceManiac/SpacemanDMM/pull/354....

Spookerton

Feature Request: SHOULD_OVERRIDE / VIRTUAL

1

Basically, it would be cool to have a way to flag certain procs / variables so that you indicate that they must be overridden in derivate paths, eg: ``` /datum/food...

FluffyGhoster

`transform.Translate(1, 1).Scale(3, 3)` lints as needing a static type

Mothblocks

Throw a warning for the following: ```dm my_var = my_var ``` ```dm my_var.field = my_var.field ``` Ie when both sides of the assign are variable accesses or field accesses and...

alexkar598

## Details First noticed this while making our codebase compatible with OpenDream. https://github.com/Citadel-Station-13/Citadel-Station-13-RP/blob/6085261718f4e0c5cdc33fa93d641ed080484d09/code/game/objects/items/stacks/sandbag.dm#L52 From what I've tested, this only happens to types, procs will error for other reasons to prevent...

Zandario

Should not sleep Fixes

7

Fixes #355 Also splits SHOULD_NOT_SLEEP and SHOULD_BE_PURE tests and adds a minor improvement to the test helpers in that it shows more info where it wouldn't when `panic`ing

Cyberboss

``` /datum/braced{ var/a; /proc/foo() return ``` 0 errors in langserver on a test project

Cyberboss

Evaluate __FILE__ and __LINE__ and put them in the doc comments

1

 

Cyberboss

Missed sleep with SHOULD_NOT_SLEEP

1

This errors in dreamchecker as expected ```dm /datum/proc/is_valid(value) SHOULD_NOT_SLEEP(TRUE) /datum/choiced/is_valid(value) get_choices() /datum/choiced/proc/get_choices() init_possible_values() /datum/choiced/proc/init_possible_values() /datum/choiced/ai_core_display/init_possible_values() sleep(1) ``` This doesn't ```dm /datum/proc/is_valid(value) SHOULD_NOT_SLEEP(TRUE) /datum/choiced/is_valid(value) get_choices() /datum/choiced/proc/get_choices() init_possible_values() /datum/choiced/proc/init_possible_values() /datum/choiced/ai_core_display/init_possible_values() stoplag() /proc/stoplag()...

Cyberboss