SpacemanDMM icon indicating copy to clipboard operation
SpacemanDMM copied to clipboard

SHOULD_NOT_SLEEP and SHOULD_BE_PURE have false positives based on incorrect inheritance assumptions

Open out-of-phaze opened this issue 2 years ago • 1 comments

/proc/foo()
    SHOULD_NOT_SLEEP(TRUE)

/datum/proc/foo()
    sleep(5)

/datum/proc/foo() will report that it has SHOULD_NOT_SLEEP set when it shouldn't.

out-of-phaze avatar Aug 23 '22 03:08 out-of-phaze

image An example in a real environment, although the proc didn't originally have the annotation--it was added for demonstration.

out-of-phaze avatar Aug 23 '22 03:08 out-of-phaze