lunar-unity-console icon indicating copy to clipboard operation
lunar-unity-console copied to clipboard

Published 20 hours ago • verified publisher icon SpaceMadness

Variables Removal

Open Vukiz opened this issue 3 years ago • 7 comments

added support to remove variables It can be used to create dynamic menus in plugin - so you can add or remove variables on button clicked.

Vukiz avatar May 06 '21 18:05 Vukiz

Hey @Vukiz, thanks for the PR! There're 2 things we need to address before merging:

  • Can you fix the broken unit test ion iOS: Native/iOS/LunarConsole/LunarConsoleTests/LUActionRegistryFilterTest.swift:54:7: Type 'LUActionRegistryFilterTest' does not conform to protocol 'LUActionRegistryFilterDelegate'?
  • Can you sign the Individual Contributor License Agreement (CLA)?

weeeBox avatar May 09 '21 15:05 weeeBox

Hey, @weeeBox! Finally won in a battle of me vs syntax. Fixed issues with tests and signed CLA.

Vukiz avatar May 11 '21 12:05 Vukiz

@Vukiz, cool - thanks! Things are a bit busy on my end right now - I'll try to review and merge until the end of the week!

weeeBox avatar May 12 '21 00:05 weeeBox

@Vukiz, why do we need a projmods file here: Native/iOS/LunarConsole/LunarConsole/Lunar.projmods?

weeeBox avatar May 16 '21 20:05 weeeBox

@Vukiz, why do we need a projmods file here: Native/iOS/LunarConsole/LunarConsole/Lunar.projmods?

Seems like I'm using XUPorter(https://github.com/onevcat/XUPorter) without knowing it. Without .projmods file after build xcode project I need to manually add Lunar lib to xcode project or to write a postprocessor so this files would be linked. Should I delete this file?

Vukiz avatar May 17 '21 06:05 Vukiz

There's a build post-processor already. I think we can delete the projmods file.

weeeBox avatar May 17 '21 13:05 weeeBox

Yeah, for some reason that didn't work in my projects. Removed this file anyways.

Vukiz avatar May 17 '21 14:05 Vukiz