SpaceIm

Results 220 comments of SpaceIm

@SteB0 I think MinGW is fixed now with https://github.com/flexible-collision-library/fcl/pull/461/commits/af00cc29bffc9eb9a9523651df8bff9818db3d26 (may be tedious to review). The shared library builds and links, as well as the tests, even when all symbols are...

@SeanCurtis-TRI @jamiesnape @sherm1 I've fixed all the autoformatting mess, now only remain relevant modifications.

Those are the only 2 members functions without definitions Visual Studio reported during compilation. There is also something, slightly different, for which Visual Studio reports a warning: it says that...

Since commits in #851 don't land in any release for the moment, I guess that this change is harmless. It could eventually break people who were using master branch.

I forgot: do be consistent with 1.0.0, `BUILD_SHARED_LIBS` could be turned to an option set to ON by default. > For some reason, I thought #851 was in v1.0.0. I...

> This file is used by cpack when building a nuget package. > > https://github.com/redis/hiredis/blob/master/hiredis.targets > > Will the shared and static packages have different IDs? I don't know nuget,...

I've submitted a PR in conan-center-index for 0.8.0: https://github.com/conan-io/conan-center-index/pull/1489

> @SpaceIm can you explain what the **specific** issue(s) it is causing for Conan? If it's a case of adding geosop back then I'm fine with it, but are there...

> > since it was the only issue with add_subdirectory(). All other logic based on PROJECT_IS_TOP_LEVEL can be removed I think. > > No, CMAKE_SOURCE_DIR/CMAKE_BINARY_DIR are real problems when using...