SpaceIm

Results 220 comments of SpaceIm

IMHO, options which are not used at all should be removed in configure() not package_id(). Options which are used in build(), package() etc but don't change package id should be...

Actually, `cxx_std_` needs at least 3.8, even `cxx_std_11`

The check should be more powerful. `KEEP_RPATHS` may not be sufficient (and limited to CMake based recipes), it depends whether upstream is doing install_name babysitting. This hook should inspect produced...

It's worth noting that I still don't know how to install shared libs with `@rpath` install_name with Meson (currently, all Meson based recipes put absolute path in install_name, like autotools,...

> but in general, my point that hook should be irrelevant to the build system Agree, I just want to say that before adding any hook in conan-center, we should...

Regarding Meson, I asked on Slack but never get any answer: https://cpplang.slack.com/archives/C01AVS654P8/p1643164802012000 This PR seems to have removed any capability to install relocatable shared libs on macOS with Meson: https://github.com/mesonbuild/meson/pull/3691...

Agree, while many `self.settings.os == "Macos"` should be replaced by `tools.is_apple_os(self.settings.os)`, there is no simple rule.

Hooks shouldn't prevent a library to have .dll/.dylib/.so in the package folder if static. Instead, check for existence of at least one .a/.lib

PhysX for example: - if static, there are anyway one or two shared libs. - if shared, there are anyway four static libs.