SpaceIm

Results 220 comments of SpaceIm

Actually it seems that layout() set resdirs to empty /cc @uilianries @SSE4 @prince-chrismc for documentation in CCI

What about the new method `validate_build()`?

Where do you define EASTL_API as __declspec(dllexport) during build? It's dllimport in config.h, therefore this file is for consumer not for build (unless EASTL_API is externally defined as dllexport if...

`INSTALL_NAME_DIR` is irrelevant on non-Mac platforms: https://cmake.org/cmake/help/latest/prop_tgt/INSTALL_NAME_DIR.html And the default behavior of CMake is to make shared libs on macOS rpath friendly (which means relocatables) like you have for free...

closed by https://github.com/conan-io/conan/pull/12094

Shouldn't `_WINDOWS` macro be replaced by `_WIN32` here: https://github.com/zlib-ng/minizip-ng/blob/1593060ecf093411f1f20f655e50992913c6d5b9/mz.h#L150-L154

AFAIK, `_WINDOWS` definition doesn't exist (or it's not standard on Windows compilers), `_WIN32` should be used to detect windows. This simple macro should be sufficient: ```c++ #ifndef MZ_EXPORTS #define MZ_EXPORT...

`_WINDOWS` is not listed in https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160, it's the first time I see this macro. > We would end up exposing almost all of the functions with `MZ_EXPORT` so it doesn't...

If you're using MinGW with win32 threads, it just can't work. Use MinGW with posix threads.

I don't know what may happen in vcpkg, but for sure a vcpkg port issue shouldn't lead to introduction of bad practice in your lib. It works just fine in...