Solar Mithril comments

Results 25 comments of


                                            Solar Mithril

Add dt.quarter_start, dt.quarter_end, dt.year_start and dt.year_end

Thanks! I will do refactoring and tests now

Add dt.quarter_start, dt.quarter_end, dt.year_start and dt.year_end

@mcrumiller @MarcoGorelli Refactoring, Tests and docs are done. Few questions: 1. Wdyt about naming of `pub(crate) enum RollUnit { Month, Quarter, Year, }` - maybe there is better fitting name?...

[Feature] Configuration flag to allow possible 'null' blocks on a network

Also, erigon clients for Polygon and BSC have kinda same problems. Some blocks (state transactions) do not return transactions and it causes the graph to treat it as reorg and...

[Feature] Add graphman unlink

Hi @azf20 Yes, I'll speed up :)

[Feature] Add graphman unlink

@lutter Could you provide concrete fields for the auditing table? I cannot find any mention of it anywhere. Or we could add auditing in another PR.

[Bug] Local graph-node in docker shuts immediately after processing event

Code 137 could indicate OOM kill. You could check that you have enough memory for the graph to run on your machine. You could run top/htop during graph execution.

Improve fetch_historic_logs_stream logic

No, it's a little different case We could have blocks without relevant logs for smart contract. In this case such a block at the end of the range (considering this...

Improve fetch_historic_logs_stream logic

> i wonder why i did this 🤔 in turn this would mean we could remove `if logs_empty {` and then the whole `if let Some(last_log) = last_log {...` downwards...

feat(rust, python): add dt.quarter_start, dt.quarter_end, dt.year_start and dt.year_end

All comments were addressed @MarcoGorelli

feat(rust, python): add dt.quarter_start, dt.quarter_end, dt.year_start and dt.year_end

@MarcoGorelli done :)