sovereign-sdk icon indicating copy to clipboard operation
sovereign-sdk copied to clipboard

Clean up incorrect and stale docker volumes automatically

Open dubbelosix opened this issue 1 year ago • 4 comments

https://github.com/Sovereign-Labs/sovereign-sdk/issues/1159#issuecomment-1821947403

So it seems like docker-compose is not re-creating the volumes. This could continue impacting users especially if they switch between demo-rollup in sovereign repo and starter-rollup since both of them use different credentials paths for the volume.

one simple fix is to just have the makefile detect and delete volumes every time (the credentials folder is very light weight. < 1kb) another approach is to just use different volume names for both

dubbelosix avatar Nov 23 '23 17:11 dubbelosix

I'd lean toward just deleting the volumes. That way things don't break when someone has two forks of a package

preston-evans98 avatar Nov 23 '23 17:11 preston-evans98

I'm not sure what is the way to reproduce this, however the credentials persists because the sequencer address is hardcoded

zvolin avatar Nov 24 '23 23:11 zvolin

is there any reproduction from non mac-os? I started to think it's a bug in compose local volume driver specific to this system

zvolin avatar Nov 25 '23 00:11 zvolin

hmm indeed if you have 2 different projects with the same docker layout and volume names, they will never be recreated so you have to either name it differently or delete them on the startup

zvolin avatar Nov 28 '23 15:11 zvolin