souvik

Results 75 comments of souvik

Yeah, I have bumped the generator version, pr is ready for review now.

Oh sorry, I was kinda confused about how the CLI's watcher is working https://github.com/asyncapi/cli/blob/b0cd740a6b405c04c092345c1db02097ee53c47c/src/globals.ts#L28, I will give another try, give me some time on this. > @Souvikns If you want,...

The watcher is not working correctly. Getting this error ``` ➜ ./bin/run generate https://bit.ly/asyncapi @asyncapi/html-template --output ./docs -w Error: Cannot find module '/Users/postman/Documents/GitHub/cli/@asyncapi/html-template/package.json' Require stack: - /Users/postman/Documents/GitHub/cli/lib/commands/generate.js - /Users/postman/Documents/GitHub/cli/node_modules/@oclif/core/lib/module-loader.js -...

Thanks, to @magicmatatjahu implementation, is ready, @derberg I think you can do manual tests now.

I didn't use the `load` function because the generator supports both file system path and URL. Even if we use the load function we sill need to pass the input...

😆 sorry, we are using the `load` function [here](https://github.com/Souvikns/cli/blob/426c3611e9c739aa819ef8408f75c00e559655a0/src/commands/generate.ts#L197). Then @derberg shall we just move the command under `generate template`?

> to be fair with contributor, we should first merge modelina, and then this 😉 unless he is ok with your suggestion. Sure @derberg I have no problem waiting, let's...

Yeah, it does not support out of the box for topic, I forgot to add the workaround for the `generate` command. ``` cli on  generator-command is 📦 v0.21.0 via...

@derberg it is ready for review 👍🏼

`base.ts` was like a base class that only implements the error handling. We kind of followed this, https://oclif.io/docs/error_handling#error-handling-in-the-catch-method, and if we throw the error oclif has a global error handler...