node-x509 icon indicating copy to clipboard operation
node-x509 copied to clipboard

Fix building with node 10.0.0

Open Paxa opened this issue 6 years ago • 24 comments

I found this useful patch in https://github.com/Southern/node-x509/issues/68 (i'm not an author of this changes)

Thank you @stormwin

Paxa avatar Jul 07 '18 18:07 Paxa

If i have more free time, i will fix backward incompatibilities with older nodejs versions. The problem is with OpenSSL version that is changed from 1.0.x to 1.1.x in nodeJS v10.x

stormwin avatar Jul 08 '18 17:07 stormwin

OK, finally it work on every nodejs version.

stormwin avatar Jul 08 '18 21:07 stormwin

Bravo!

Paxa avatar Jul 09 '18 05:07 Paxa

@Southern bump plz (needed for node-solid)

jacobpdq avatar Jul 14 '18 12:07 jacobpdq

plz merge it

alexanderkhivrych avatar Jul 19 '18 14:07 alexanderkhivrych

ASAP

alexanderkhivrych avatar Jul 19 '18 14:07 alexanderkhivrych

build already green

alexanderkhivrych avatar Jul 19 '18 14:07 alexanderkhivrych

@stormwin

alexanderkhivrych avatar Jul 19 '18 14:07 alexanderkhivrych

I am also waiting for this merge. Till then, i am using my own fork in my projects

stormwin avatar Jul 19 '18 19:07 stormwin

Bump

On Thu, Jul 19, 2018, 3:16 PM Vlado Velichkovski [email protected] wrote:

I am also waiting for this merge. Till then, i am using my own fork in my projects

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Southern/node-x509/pull/71#issuecomment-406384975, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKBbE7w5wNheCYxJcbCNeN-Z_60dYH2ks5uINr0gaJpZM4VGc1- .

jacobpdq avatar Jul 19 '18 21:07 jacobpdq

@Southern

alexanderkhivrych avatar Jul 23 '18 07:07 alexanderkhivrych

Guys, you can just use it from github: yarn add stormwin/node-x509 or npm i stormwin/node-x509

Paxa avatar Jul 23 '18 07:07 Paxa

@Paxa Thanks for this patch very much, may I ask you not to change the coding style, such that we could merge them only with building patch :)

yorkie avatar Jul 28 '18 08:07 yorkie

@yorkie I just created a PR from @stormwin fork

Paxa avatar Jul 28 '18 10:07 Paxa

Did the project die?

eduardocruz avatar Sep 17 '18 16:09 eduardocruz

Bump

adamhamlin avatar Nov 01 '18 20:11 adamhamlin

Can this be merged please?

mbwhite avatar Nov 16 '18 15:11 mbwhite

Can this be merged please?

@mbwhite Sorry for the late, already leave comments here though the CI is pass :)

yorkie avatar Nov 17 '18 10:11 yorkie

OK, i will try to fix this styling stuffs and also will try to fix some warnings for node v11. Will do a new commits today or tomorrow

stormwin avatar Nov 17 '18 14:11 stormwin

@stormwin you awesome! thanks for fixing this, hoping to see it merged

ghost avatar Nov 23 '18 13:11 ghost

Bump. @stormwin any chance that you fixed that styling ?

okonon avatar Nov 30 '18 02:11 okonon

Anyone can resolve the conflicts?

okonon avatar Jan 11 '19 19:01 okonon

there any follow up?

prompt-bot avatar Mar 14 '19 15:03 prompt-bot

there any follow up?

We would have preferred to use this repo - but due to schedules we had to fork and republished to npm.

mbwhite avatar Mar 17 '19 21:03 mbwhite