node-x509
node-x509 copied to clipboard
Fix building with node 10.0.0
I found this useful patch in https://github.com/Southern/node-x509/issues/68 (i'm not an author of this changes)
Thank you @stormwin
If i have more free time, i will fix backward incompatibilities with older nodejs versions. The problem is with OpenSSL version that is changed from 1.0.x to 1.1.x in nodeJS v10.x
OK, finally it work on every nodejs version.
Bravo!
@Southern bump plz (needed for node-solid)
plz merge it
ASAP
build already green
@stormwin
I am also waiting for this merge. Till then, i am using my own fork in my projects
Bump
On Thu, Jul 19, 2018, 3:16 PM Vlado Velichkovski [email protected] wrote:
I am also waiting for this merge. Till then, i am using my own fork in my projects
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Southern/node-x509/pull/71#issuecomment-406384975, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKBbE7w5wNheCYxJcbCNeN-Z_60dYH2ks5uINr0gaJpZM4VGc1- .
@Southern
Guys, you can just use it from github: yarn add stormwin/node-x509
or npm i stormwin/node-x509
@Paxa Thanks for this patch very much, may I ask you not to change the coding style, such that we could merge them only with building patch :)
@yorkie I just created a PR from @stormwin fork
Did the project die?
Bump
Can this be merged please?
Can this be merged please?
@mbwhite Sorry for the late, already leave comments here though the CI is pass :)
OK, i will try to fix this styling stuffs and also will try to fix some warnings for node v11. Will do a new commits today or tomorrow
@stormwin you awesome! thanks for fixing this, hoping to see it merged
Bump. @stormwin any chance that you fixed that styling ?
Anyone can resolve the conflicts?
there any follow up?
there any follow up?
We would have preferred to use this repo - but due to schedules we had to fork and republished to npm.