node-x509 icon indicating copy to clipboard operation
node-x509 copied to clipboard

Support path OR string

Open scottmas opened this issue 8 years ago • 3 comments

I'm re-opening this PR that @astitt-ripple started. I cleaned up index.js a bit to follow the node conventions.

I took the liberty of polyfilling Promise since it's clear from our .travis.yml that we support Node 0.10.

I also took the liberty of returning the parsed certificate in the verify callback, since we already have that info and it will likely save people some hassle depending on their use case.

scottmas avatar Jun 21 '17 18:06 scottmas

This PR is an updated version of https://github.com/Southern/node-x509/pull/47

scottmas avatar Jun 21 '17 21:06 scottmas

@Southern You get a chance to look at this?

scottmas avatar Jun 23 '17 17:06 scottmas

Heads up that I believe there are some build issues that need resolving on this PR. It usually works, but I have experienced some flakiness when building it as a dependency of a dependency.

scottmas avatar Jul 07 '17 20:07 scottmas