Steven

Results 31 comments of Steven

@garethbowen Hi, can you re-execute the ci-workflow? (best case: running only the failing tests) There was a network problem in two test-runner environments: (one of the error-messages as an example)...

Sounds like a plan 👍 I'd like to see #8665 and #8663 in an upcoming major. But this summer I'm to short on spare time to work on #8711...

> > I don't think we should be shy about dropping support for EOL'd node versions. Even node 16 is EOL at this point. > > I agree, but needs...

> > However I'm a little concerned about dropping support for Node 14, not because we shouldn't do it, but it's a breaking change so we should probably do a...

Found (and fixed) out-of-bound exceptions: #8861

Okay, everything's ✅ Next step: out with the old Branch protection rules (node 14-16) and in with the new (18-20)

I expect, Node 18 should work fine. In #8664, I've tinkered a little bit with the future, node 20 seems to be a little bit more problematic.

@DougReeder the test-suite is flaky in every node version... I don't expect some wonder, by just updating to another version 😉

https://github.com/pouchdb/pouchdb/actions/runs/6509460488/job/17681109144?pr=8775#step:4:4609 ``` 1) test.issue3179.js-local-http #3179 conflicts synced, non-live sync: AssertionError: conflicts expected, but none were found: expected undefined to exist at doAsserterAsyncAndAddThen (node_modules/chai-as-promised/lib/chai-as-promised.js:296:33) at Assertion. (node_modules/chai-as-promised/lib/chai-as-promised.js:286:25) at Assertion.get (node_modules/chai/lib/chai/utils/overwriteProperty.js:50:37) at...