Mesen2 icon indicating copy to clipboard operation
Mesen2 copied to clipboard

Debugger: Tilemap Viewer - Add 8x8 option to Edit Tiles menu and View in Memory for attribute value

Open gzip opened this issue 1 year ago • 4 comments

@SourMesen

The Edit Tiles context menu in Tilemap Viewer has been a very useful feature but occasionally a few more tiles would be helpful. I figured a jump to the next power of 2 should be plenty going forward.

Tilemap Viewer was also lacking a menu item to jump to the attribute value in memory. Before one had to take note of the attribute address, open Memory Viewer, select PPU Memory, and goto the address. A context menu is much more convenient. I patterned the text after the two add breakpoint items.

(Sorry about the whitespace changes, it's a setting in my editor and I didn't notice them until now since they're ignored in my command line diff.)

gzip avatar Mar 29 '24 23:03 gzip

Might want to review with whitespace ignored.

gzip avatar Mar 29 '24 23:03 gzip

@SourMesen These are features that I requested on the nesdev forums in January of last year so they might be on your todo list.

gzip avatar Mar 30 '24 21:03 gzip

Thanks for the PRs!

I'm unfortunately going to be busy with RL stuff for the next 3 weeks, and likely won't have the time to look at these until around the end of April, sorry!

At first glance the code seems fine, so I should be able to merge these once I get back home.

SourMesen avatar Apr 02 '24 00:04 SourMesen

Thanks for the heads up. Safe travels.

gzip avatar Apr 02 '24 02:04 gzip