mx-puppet-slack
mx-puppet-slack copied to clipboard
Sorunome
titles for newly created rooms are ignoring NamePatterns
namePatterns:
user: :name [:team? - :team,] Slack
room: :name [:team? - :team,] Slack
group: :name - Slack
{
"type": "m.room.canonical_alias",
"sender": "@slackbot:eric.nova.chat",
"content": {
"alias": null,
"alt_aliases": [
"#slack1__t02_a11_s1_m=2d_g_e_y5_l_d_e8_m:eric.nova.chat"
]
},
"state_key": "",
"origin_server_ts": 1586316519983,
"unsigned": {
"age": 2702
},
"event_id": "$M9N6QthSmG3XVmSptLF3CvD6my5WHGYs8PHqH67Tfnw",
"room_id": "!LFwfUKtkhJBUzfGHdL:eric.nova.chat"
}
This is a riot-web bug then, not following the spec. Mind opening an issue with them, that they are calculating the room name wrong?
It worked 2-3 days ago, before a recent update to mx-puppet-slack. I haven't changed anything in the config.yaml.
spec says that alt_aliases must be ignored when calculating the room name, which doesn't seem to be the case here :/
Where is the correct room name being listed? the name in slack is 'jared, steph' and with my name pattern it should be 'jared, steph - YC Slack'
The room name should be empty and no canonical alias is set - as such riot should calculate it off of the participants
Hmm so then names would revert back to things like mpdm-jared--ericmigi--uri-1 - YC Slack?
that part should be taken care of by now, too, that they don't do that
Am 8. April 2020 22:11:38 MESZ schrieb Eric Migicovsky [email protected]:
Hmm so then names would revert back to things like
mpdm-jared--ericmigi--uri-1 - YC Slack?-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/Sorunome/mx-puppet-slack/issues/50#issuecomment-611168749
looks like riot.im/app is not rendering the room names correctly. Is this still a riot problem?
latest dockerhub release
what does the m.room.canonical_alias state event look like? Accessible via /devtools
{
"type": "m.room.canonical_alias",
"sender": "@_eric_slack_bot:nova.chat",
"content": {
"alias": null,
"alt_aliases": [
"#_eric_slack___t02_a11_s1_m=2d_c012_c_b_k_e3_q_e:nova.chat"
]
},
"state_key": "",
"origin_server_ts": 1587944126015,
"unsigned": {
"age": 34298
},
"event_id": "$cx3AN3sOM9_YodmAKAlK6fxl_vYJ0rymvTrLqvubPxo",
"room_id": "!BeOWovhVCIfcuOBNbh:nova.chat"
}
no listing for m.room.alias
Alright, that looks like a riot-web bug, then. They are not following the spec by not ignoring alt_aliases
@Sorunome riot-web says: “The spec says Note that clients should avoid using alt_aliases when calculating the room name. Note it does not say must so it is not in breach of the spec.”
Well...use a different client, then :/
Am 2. Juni 2020 19:15:25 MESZ schrieb Julian Strobl [email protected]:
@Sorunome riot-web says: “The spec says Note that clients should avoid using alt_aliases when calculating the room name.> Note it does not say must so it is not in breach of the spec.”>
-- > You are receiving this because you were mentioned.> Reply to this email directly or view it on GitHub:> https://github.com/Sorunome/mx-puppet-slack/issues/50#issuecomment-637689544
If they decide to do their own thing and not follow the spec? SHOULD is a strong recommendation. SHOULD isn't COULD.
Not the first time seeing such stuff :/
Am 2. Juni 2020 19:15:25 MESZ schrieb Julian Strobl [email protected]:
@Sorunome riot-web says: “The spec says Note that clients should avoid using alt_aliases when calculating the room name.> Note it does not say must so it is not in breach of the spec.”>
-- > You are receiving this because you were mentioned.> Reply to this email directly or view it on GitHub:> https://github.com/Sorunome/mx-puppet-slack/issues/50#issuecomment-637689544
Like with iOS, RiotX client on Android also does not experience this issue. It looks like it is only electron-based clients then.
A question: since this is only happening on mpim groups, but regular channels work fine, can't you use same naming method that works for both mpim and channels?
as mpim channels don't have a name at all, their name is expected to be calculated out of the name of the participants. By leaving the canoncial_alias blank, the client should do that.
Normal channels don't have that issue as they have an explicit name set.
Maybe, until Riot fixes things, you could set the name of the explicitly on the server? Then this feature can be removed if/when Riot actually fixes this on their side.
No, that will lead to more hassle and stuff, and once riot fixes itit'll have to be reverted.
Soru already catered to quite a few weird quirks of riot, but the reward simply isn't large enough for this. Riot just has to fix it. Tell them about how important it us to fix this, instead.
Am 8. Juni 2020 13:30:07 MESZ schrieb "Matej Drobnič" [email protected]:
Maybe, until Riot fixes things, you could set the name of the explicitly on the server? Then this feature can be removed if/when Riot actually fixes this on their side.
-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/Sorunome/mx-puppet-slack/issues/50#issuecomment-640545762
There doesn't seem to be any movement on the Riot/Element side of things, here. And given this likely impacts a lot of projects using the JS SDK, any chance we could revisit the idea of a workaround? Unfortunately, as it stands, the bridge is pretty broken for me given how many group chats I find myself in...
