vue.draggable.next icon indicating copy to clipboard operation
vue.draggable.next copied to clipboard

Fix for issue 34, switched this.$el with evt.from

Open alnumac opened this issue 4 years ago • 8 comments

onDragUpdate was updated to use evt.from to call insertNodeAt, but onDragRemove was not updated accordingly.

This pull request simply corrects this slight oversight, fixing a crash I was experiencing.

alnumac avatar Jun 03 '21 20:06 alnumac

@alnumac Could you specify which scenario this fix is correcting?

David-Desmaisons avatar Aug 22 '21 21:08 David-Desmaisons

@David-Desmaisons Moving an item from one list to another with animations enabled.

alnumac avatar Sep 04 '21 15:09 alnumac

Yes, i have the same problem, and looking for this. fix. Have to disable animation for current version. There is no such problem for previous vue2 version.

cybersturmer avatar Sep 04 '21 20:09 cybersturmer

@alnumac I will appreciate if you can do this fix. i use it here: https://github.com/cybersturmer/pmdragon-client/blob/cee26d62eb86b031c4ddb8d567e10cedf154271b/src/pages/dash/Backlog.vue#L193

and here: https://github.com/cybersturmer/pmdragon-client/blob/cee26d62eb86b031c4ddb8d567e10cedf154271b/src/pages/dash/Board.vue#L131

cybersturmer avatar Sep 04 '21 20:09 cybersturmer

Please correct this bug and push a new release! Thank you So much!

atom-git avatar Oct 26 '21 08:10 atom-git

I also would be in favor of merging and releasing this as I just now ran into the same issue while upgrading a vue2 project to vue3 and moving items between lists of the same group throws the Cannot read properties of undefined error inside the onDragRemove function, I'm also using the transition-group with the animation prop. only workaround for now is removing the transition-group and the animation prop

JanLunge avatar Dec 07 '21 00:12 JanLunge

@David-Desmaisons what is missing for this to be merged?

Coding-Kiwi avatar Dec 13 '21 18:12 Coding-Kiwi

Please merge this PR and push a new release! Thanks very much!

vform666 avatar Dec 27 '21 10:12 vform666