ngx-sortablejs icon indicating copy to clipboard operation
ngx-sortablejs copied to clipboard

feat: migrate to Angular 12

Open Anikethana opened this issue 2 years ago • 16 comments

Used ng upgrade to update

Anikethana avatar Sep 18 '21 00:09 Anikethana

Can you merge this PR? I need support for Angular 12 for my project

Anikethana avatar Sep 18 '21 00:09 Anikethana

@smnbbrv Can you merge/release this? Or maybe can you give us a contact from someone who could do that for this repository?

nicolashenry avatar Nov 17 '21 00:11 nicolashenry

Can we merge this branch. I think many people who want to use sortablejs would need this. If it's unsupported maybe a new maintainer could be found?

Deitsch avatar Nov 24 '21 19:11 Deitsch

I'm very Sorry for tagging you, but could you please merge this ? This is here already for 4 months @gutenye @David-Desmaisons @andresin87 @eriklieben @matyas-igor @depuits @smnbbrv @owen-m1

Reixko avatar Jan 24 '22 15:01 Reixko

I'm very Sorry for tagging you, but could you please merge this ? This is here already for 4 months @gutenye @David-Desmaisons @andresin87 @eriklieben @matyas-igor @depuits @smnbbrv @owen-m1

I'm sorry. I just got enrolled to the team half a month ago just for the react sortable binding project.

andresin87 avatar Jan 25 '22 09:01 andresin87

No problem, could you maybe ping someone from the team that can merge this ? Because if they enrolled you, then it means that atleast someone is active :) Thank you @andresin87

Reixko avatar Jan 25 '22 16:01 Reixko

@Anikethana I believe that we should add "compilationMode": "partial" in the libs prod tsconfig

https://angular.io/guide/creating-libraries#ensuring-library-version-compatibility

spierala avatar Apr 15 '22 09:04 spierala

Also need to update peerDependencies on package.json

jpark011 avatar Apr 19 '22 00:04 jpark011

Used ng upgrade to update

Can you also update package.json file

kiran-pathe avatar Apr 20 '22 17:04 kiran-pathe

Is this project dead?

Klapik avatar Jul 11 '22 19:07 Klapik

seems to be dead, i wouldn't use it if you have other options

Deitsch avatar Jul 12 '22 09:07 Deitsch

Unfortunately, I can't find a good alternative. Dragula is also dead for quite some time now.

COBRASoft5 avatar Jul 12 '22 09:07 COBRASoft5

This are some alternatives that are maintained. The downside of the first and second is that they aren't as conveniently wrapped for Angular. But it recommend going down this path rather then to use the seemingly unmaintained sortablejs

https://github.com/Shopify/draggable
https://github.com/taye/interact.js
https://material.angular.io/cdk/drag-drop/overview

Also simple stuff can be done using the HTML drag API. It's not too shabby. I created my own directives for a folder like, multi object dnd

Deitsch avatar Jul 12 '22 09:07 Deitsch

SortableJS is one of the only frameworks that works nicely together with multiple columns and rows (grid). Most others, like cdk, don't have nice animations or don't work at all in a grid display.

Edit: seems draggable is not very well maintained either as mentioned on their github page.

COBRASoft5 avatar Jul 12 '22 10:07 COBRASoft5

You are right about draggable, but at the moment is maintained and they search for maintainers, so i'd say it is a valid option.

I mean you always can fork ngx-sortableJS it and bring it up to Angular 14 (or whatever version u need)

Deitsch avatar Jul 12 '22 12:07 Deitsch

@smnbbrv possible to update or assign to someone new maintaining it? sorry to see this lib not being maintained. Angular native DragDrop has its downsides ...

AlexanderStromer avatar Oct 10 '23 04:10 AlexanderStromer