Sortable icon indicating copy to clipboard operation
Sortable copied to clipboard

AutoScroll overflow:hidden demo not working

Open ligne13 opened this issue 5 years ago • 6 comments

Problem:

The given demo does not work (Chrome 79, Mac OS Catalina): https://jsbin.com/xecihez/edit?html,js The list is not scrolling during a drag.

JSBin/JSFiddle demonstrating the problem:

https://jsbin.com/xecihez/edit?html,js,output

ligne13 avatar Feb 01 '20 16:02 ligne13

This looks like a bug. Even with overflow off, it still doesn't scroll when I believe it should.

We'll have to look into this further.

waynevanson avatar Feb 12 '20 00:02 waynevanson

@waynevanson Any updates on this?

croossin avatar Mar 24 '20 16:03 croossin

I've only narrowed it down to a change made in the 1.8.0 release. If you change the JS Bin example to use /1.7.0/ instead of /master/ in the script tag, autoscroll works again. /1.8.0/ and later break. Will try to look soon, but it looks like that was a large release.

~Possibly related to https://github.com/SortableJS/Sortable/issues/1373?~

Narrowed further to a change in commit 18cccbac11e2e050155878bc250fea6a6042d50f / PR #1386.

I've looked further into this, but I'm not close enough to this code to know what's going on anymore. Something with how the code since bubbleScroll was added handles finding and item's scroll-parent seems wonky, but I'm at a loss.

ahamilton9 avatar Jul 29 '20 18:07 ahamilton9

is this related to https://github.com/SortableJS/sortablejs/pull/1403 ?

simonsonga avatar Nov 13 '20 13:11 simonsonga

any updates on this?

el-Rey-magico avatar Mar 15 '21 21:03 el-Rey-magico

any updates on this?

gregveres avatar Oct 18 '23 12:10 gregveres