Sorcery
Unable to commit to master
Hi @joshbuker, I've been unable to commit the version bump to master per the instructions. That might be a permissions thing in GitHub?
It says you should be able to override when I look at the branch protections... 🤷
Oh I think this is when I try to commit directly to master which is what I usually do for the version file before release. I suppose I could do a PR for this instead. Is that what you used to do?
Sorry, I meant you should be able to override the branch protection and push straight to master
Interesting, perhaps using the web interface, but I'm using GitHub Desktop. I'll try via the web :)
Doesn't seem to work there either. Is there a special tag for the commit that will allow it to be bypassed?
It’s probably the case that neither @brendon nor I have permission to change the branch protection rule that prevents direct pushes to master. However, since we can still change the version by opening a PR that updates version.rb and merging it, I don’t think we need to forcefully change the current rules.
When I update my other gems, I usually just push changes to version.rb directly to the master (main) branch. But Sorcery is an authentication gem and likely has many users, so I think it’s better to operate on the safer side here.
Long term it would be nice to allow maintainers to push directly, but using a PR is an acceptable workaround until we figure out which setting does the trick while keeping branch protection enabled otherwise.
Let's see if the collective knowledge of the entire internet can figure it out ;D
I suspect this is due to attempting to push from local instead of fork/master with passing tests, see: https://github.com/Sorcery/sorcery/pull/415#issuecomment-3627792166